Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out an AOT-friendly solution for the Protocol Buffers usage in ClientMessageServer #31

Open
alexrp opened this issue May 23, 2022 · 2 comments
Open

Figure out an AOT-friendly solution for the Protocol Buffers usage in ClientMessageServer #31

alexrp opened this issue May 23, 2022 · 2 comments
Assignees
@alexrp
Labels
area: client Issues related to the launcher/client APIs. cpu: x86 64 Issues that are specific to x86 (64-bit). os: windows Issues that are specific to Windows (10, 11, etc). state: approved Enhancements and tasks that have been approved.
Milestone
v4.0

Comments

@alexrp
Copy link
Member

alexrp commented May 23, 2022

novadrop/src/client/Client/ClientServerList.proto

Line 10 in 09d3a61

// TODO: protobuf-net is not currently AOT-friendly.

@alexrp alexrp added state: approved Enhancements and tasks that have been approved. type: feature area: client Issues related to the launcher/client APIs. labels May 23, 2022
@alexrp alexrp added this to the v2.0 milestone May 23, 2022
@alexrp alexrp self-assigned this May 23, 2022
alexrp added a commit that referenced this issue May 23, 2022
@alexrp
Don't analyze Vezel.Novadrop.Client for trimming compatibility for now.
b76530b 
See: #31
@alexrp
Copy link
Member Author

alexrp commented May 23, 2022

Note: b76530b

@alexrp
Copy link
Member Author

alexrp commented May 25, 2022

Considering the simplicity of ServerList/ServerInfo, perhaps we should just go with a hand-rolled serializer based on the protobuf-net.Core APIs.

@alexrp alexrp modified the milestones: v2.0, v3.0 Jun 11, 2022
@alexrp alexrp modified the milestones: v3.0, v4.0 Aug 17, 2023
@alexrp alexrp changed the title Figure out an AOT-friendly solution for the Protocol Buffers usage in ClientProcess Figure out an AOT-friendly solution for the Protocol Buffers usage in ClientMessageServer Dec 14, 2023
@alexrp alexrp added os: windows Issues that are specific to Windows (10, 11, etc). cpu: x86 64 Issues that are specific to x86 (64-bit). labels Dec 14, 2023
@alexrp alexrp removed their assignment Jan 27, 2024
@alexrp alexrp modified the milestones: Future, v4.0 Apr 26, 2024
@alexrp alexrp self-assigned this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexrp alexrp

Labels
area: client Issues related to the launcher/client APIs. cpu: x86 64 Issues that are specific to x86 (64-bit). os: windows Issues that are specific to Windows (10, 11, etc). state: approved Enhancements and tasks that have been approved.
Milestone
v4.0
Development

No branches or pull requests
1 participant
@alexrp