chore: add missing shadow dependency #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibc
reviewed
Jun 6, 2024
|
Thanks. I will merge soon but won't be able to release until next week. |
|
CI is failing. You must run npm install types/node and commit |
Sorry for missing this. I've added the corresponding commit to the branch. Maybe we can squeeze it for clarity 😅 |
|
I need to wait a bit before merging this because we have a related issue that may need additional changes. Will be done soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npmhas a known problem of shadow dependencies.When installing with
pnpm, the package@types/nodeis not there wheretscexpects it, which itself is indirect dependency ofjest.And also, I would suggest use
pnpmas a drop-in replacement fornpm, which helps much on multi-package management, prevention of shadow deps, and quicker installation.