[WIP] Update deps libsdptransform and Catch2 #151
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update libsdptransform to v1.2.10 - Update Catch2 to v3.2.1
|
I don't know what can cause that error... I've tested the branch and it does not compile. this change is needed: --- a/test/src/tests.cpp
+++ b/test/src/tests.cpp
@@ -17,8 +17,8 @@ int main(int argc, char* argv[])
// Build a new parser on top of Catch.
// clang-format off
auto cli = session.cli()
- | Catch::clara::Opt(logLevelStr, "debug|warn|error|none")["-L"]["--log-level"]("libmediasoupclient log level (default: none)")
- | Catch::clara::Opt(webrtcLogLevelStr, "verbose|info|warn|error|none")["-W"]["--webrtc-log-level"]("libwebrtc log level (default: none)");
+ | Catch::Clara::Opt(logLevelStr, "debug|warn|error|none")["-L"]["--log-level"]("libmediasoupclient log level (default: none)")
+ | Catch::Clara::Opt(webrtcLogLevelStr, "verbose|info|warn|error|none")["-W"]["--webrtc-log-level"]("libwebrtc log level (default: none)");Then it compiles, but few test fail and there is a segfault:
I can look at it but probably not before the end of the year. |
|
@jmillan are you using this line? gn gen out/m94 --args='is_debug=false is_component_build=false is_clang=true rtc_include_tests=false rtc_use_h264=true use_rtti=true mac_deployment_target="10.11" use_custom_libcxx=false' |
|
yes, the very same from our docs. |
|
So now I have a different problem running Yes, it says:
It would be great to know what "install ninja to your project using DEPS" means... |
|
I've installed |
|
Not sure if relevant, but I have this: Xcode doesn't seem to allow installing any other macosx SDK, so I assume this is the right one. |
|
My info:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140