Change default return value of "getH264ProfileLevelId" #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello!
I suggest
getH264ProfileLevelId
behavior when profile-level-id is not found in H264 codec parameters.Now, it returns an empty string, so it will always not match when compared to codecs with a profile-level-id.
On the other hand, the H264 checker used in the JavaScript SDK returns an id of ConstrainedBaseline (Level3.1), which works differently from libmediasoupclient.
https://github.com/ibc/h264-profile-level-id/blob/8f2eee9ed846113a58b9f562947f45cd9d8f7cb9/index.js#L78
I think the JavaScript SDK is more available and should be used that way.
With this fix, I have confirmed that H264 communication with mobile devices is possible even if profile-level-id is not included in the codec parameters on the mediasoup server.