Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

happens 'icecandidate' never call with event.candidate=false #433

Closed
barmoleg opened this issue Mar 27, 2017 · 2 comments
Closed

happens 'icecandidate' never call with event.candidate=false #433

barmoleg opened this issue Mar 27, 2017 · 2 comments

Comments

@barmoleg
Copy link

barmoleg commented Mar 27, 2017

function createSucceeded(desc) {
var listener;
connection.addEventListener('icecandidate', listener = function(event) {
var candidate = event.candidate;
if (! candidate) { //-- Never happens

may be use promise?

@svarunan
Copy link

event.candidate will not be false, last event's candidate will be undefined when ice gathering is completed.
I feel you might also be seeing issues like in #432

@ibc
Copy link
Member

ibc commented Mar 30, 2017

@barmoleg as you may check, JsSIP does not remove/mangle listeners given to the underlying peerconnection:

https://github.com/versatica/JsSIP/blob/master/lib/RTCSession.js#L1544

JsSIP uses adapter.js, but AFAIS such a library neither:

https://github.com/webrtc/adapter/blob/master/src/js/chrome/chrome_shim.js

So, if candidate is never falsy/undefined/null, that's out of the scope of JsSIP and it's just a pure native RTCPeerConnection subject.

@ibc ibc closed this as completed Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants