-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing documentation or not up to date #43
Comments
@SebUndefined Thanks for pointing this out! This will all come. What you should let me know though, is when some modifier or something else is not working. 👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq |
@ioolkos thanks for your answer. I am currently developing an open source GO module that will provide all struct needed for parsing the VMQ request body and for creating the response (through builder). TS/JS will come afterwards. Is there any way for me to get all available modifiers for any hook ? Anyway I am not familiar with Erlang but I will try to have a look at the code :) ) |
@SebUndefined Awesome to hear! :) 👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq |
Ok looks good ! I will start by the documentation of my module by detailing the potential modifiers of each hook based on this link https://github.com/vernemq/vernemq/blob/c3e35e2565aa515a09eea41453e3a764259674b1/apps/vmq_plugin/src/vmq_plugin_util.erl#L99-L119. That will help me for the development. Maybe I will ask you to check it if you have time. And if you want to use it for yours, feel free. https://github.com/SebUndefined/govmq/tree/develop |
It looks like there is a problem on the webhook documentation.
In the documentation, it is written (https://docs.vernemq.com/plugin-development/webhookplugins):
"Note, the retry_interval is in milli-seconds. It is possible to override many more settings, see the Session Lifecycle for more information." (auth_on_register)
If I follow the link and go to the vernemq dev repo (https://github.com/vernemq/vernemq_dev/blob/master/src/auth_on_register_hook.erl), I can see the potentials modifiers under "reg_modifiers()" but I can't see the max_inflight_messages and retry_interval showed in the response example (still in webhook doc of auth_on_register https://docs.vernemq.com/plugin-development/webhookplugins)
Am I missing something ? Or does the documentation is ou of date ?
Thanks for your help !
The text was updated successfully, but these errors were encountered: