Merge pull request #3335 from w0lek/attempt_to_load_arch_xml_file_without_extension_leads_to_segfault

AlexandreSinger · web-flow · commit 34beda167f3f · 2025-11-06T13:28:06.000-05:00
attempt to load arch xml file without extension leads to segfault
diff --git a/libs/libarchfpga/src/read_xml_arch_file.cpp b/libs/libarchfpga/src/read_xml_arch_file.cpp
@@ -404,7 +404,7 @@ void xml_read_arch(std::string_view arch_file,
         VTR_LOG_WARN(
             "Architecture file '%s' may be in incorrect format. "
             "Expecting .xml format for architecture files.\n",
-            arch_file);
+            arch_file.data());
     }
 
     // Create a unique identifier for this architecture file based on it's contents

Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ void xml_read_arch(std::string_view arch_file,`
`404`	`404`	`VTR_LOG_WARN(`
`405`	`405`	`"Architecture file '%s' may be in incorrect format. "`
`406`	`406`	`"Expecting .xml format for architecture files.\n",`
`407`		`- arch_file);`
	`407`	`+ arch_file.data());`
`408`	`408`	`}`
`409`	`409`
`410`	`410`	`// Create a unique identifier for this architecture file based on it's contents`