Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows + TUI has tasks exit with code 3221225786 #9389

Open
1 task done
chris-olszewski opened this issue Nov 5, 2024 · 8 comments
Open
1 task done

Windows + TUI has tasks exit with code 3221225786 #9389

chris-olszewski opened this issue Nov 5, 2024 · 8 comments
Labels
kind: bug Something isn't working needs: author input

Comments

@chris-olszewski
Copy link
Member

chris-olszewski commented Nov 5, 2024 •
edited
Loading

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

Need reproduction

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Windows

Which canary version will you have in your reproduction?

2.2.3

Describe the Bug

Dev tasks are exiting prematurely with exit code 3221225786 with turbo 2.2.1 and above when using the TUI

Expected Behavior

Dev tasks should not exit prematurely when using TUI

To Reproduce

See #9304 (comment)

Additional context

I have version 2.2.3 of Windows 10, Powershell

#9304 (comment)
@chris-olszewski chris-olszewski added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Nov 5, 2024
@chris-olszewski chris-olszewski mentioned this issue Nov 5, 2024
Closed
1 task
@chris-olszewski chris-olszewski removed the needs: triage New issues get this label. Remove it after triage label Nov 5, 2024
@chris-olszewski
Copy link
Member Author

@techwithanirudh Can you list out the following:

  • OS (If using Windows, please indicate if WSL or not)
  • Terminal program
  • Shell
  • Have you made sure your console isn't in legacy mode? (Make sure to restart your computer after changing this option to make sure the Console server gets restarted)

If anyone could provide a repository that reproduces this behavior on their machine, I would be very thankful.

@techwithanirudh
Copy link

techwithanirudh commented Nov 6, 2024 •
edited
Loading

  • Operating System: Debian 12 in DevContainer
  • Terminal Program: VSCode integrated terminal
  • Shell: zsh
  • Turbo Version: 2.2.3
  • Legacy Console Mode Check: Not applicable (Debian environment)

Issue:
Running turbo dev works fine, but running turbo watch dev --continue gives the following response:
image

@chris-olszewski
Copy link
Member Author

@techwithanirudh Do the ANSI codes only appear along when there's a failed to connect to daemon error?

@chris-olszewski chris-olszewski mentioned this issue Nov 7, 2024
Merged
chris-olszewski added a commit that referenced this issue Nov 8, 2024
@chris-olszewski
fix(watch): ensure TUI is shutdown regardless of exit path (#9408)
1a9214e 
### Description

I noticed in #9389 that the
TUI wasn't exiting if `watch` exited from anything other than a `Ctrl-C`
(including a direct SIGINT to the process). This PR ensures that we shut
down the TUI and the persistent task handle regardless of how
`watch.start()` exits.

### Testing Instructions

- Start up a watch task `turbo_dev watch dev`
- Find the pid file via `turbo_dev daemon status`
- Kill the daemon `kill $(cat /path/to/pid/file)`

Before
<img width="1365" alt="Screenshot 2024-11-07 at 5 42 22 PM"
src="https://github.com/user-attachments/assets/141831b4-8a82-485e-ac14-c0d72802cf81">


After
<img width="1286" alt="Screenshot 2024-11-07 at 5 39 08 PM"
src="https://github.com/user-attachments/assets/21acddb9-ae6a-4b78-b38d-1cbe0e0d3309">
@chris-olszewski
Copy link
Member Author

@techwithanirudh If you could test out 2.2.4-canary.9, I believe turbo watch should do a better job of cleaning up the terminal regardless of why it exits.

@techwithanirudh
Copy link

techwithanirudh commented Nov 8, 2024 •
edited
Loading

@techwithanirudh Do the ANSI codes only appear along when there's a failed to connect to daemon error?

I think so, i'm gonna try testing the 2.2.4

Edit: Also happens with discovery failed: bad grpc status code: similar to #8491

@techwithanirudh
Copy link

@techwithanirudh If you could test out 2.2.4-canary.9, I believe turbo watch should do a better job of cleaning up the terminal regardless of why it exits.

@chris-olszewski Yeah, it did a pretty good job of cleaning up the ANSI codes.
CleanShot 2024-11-08 at 23 46 30@2x

@chris-olszewski
Copy link
Member Author

Thank you for testing it out! I'll try to find what's producing that final ANSI escape sequence

@kodermax
Copy link

@chris-olszewski Is there any progress in resolving this issue, or perhaps some settings in Windows could help? However, in version 2.1.3, there was no such issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug Something isn't working needs: author input
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kodermax @chris-olszewski @techwithanirudh