Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error when pnpm-workspace.yaml is missing #9224

Closed
1 task done
cjkihl opened this issue Oct 6, 2024 · 0 comments · Fixed by #9650
Closed
1 task done

Misleading error when pnpm-workspace.yaml is missing #9224

cjkihl opened this issue Oct 6, 2024 · 0 comments · Fixed by #9650
Labels
area: logging Improvements to logging

Comments

@cjkihl
Copy link

cjkihl commented Oct 6, 2024

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

pnpm dlx create-turbo@canary

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Mac

Which canary version will you have in your reproduction?

2.1.4-canary.1

Describe the Bug

If don't have a pnpm-workspace.yaml turbo throws this error which is miss leading:
× root task //#dev (turbo dev) looks like it invokes turbo and might cause a loop

Screenshot 2024-10-06 at 7 35 32 AM

Related to discussion:
#5290 (reply in thread)

Expected Behavior

A warning or error message: monorepo configuration for pnpm could not be found. Make sure you have setup workspaces correctly. See https://pnpm.io/workspaces

This will save users a lot of time debugging if they accidentally renamed or removed pnpm-workspace.yaml.

To Reproduce

1.Download a new turbo repo starter with pnpm pnpm dlx create-turbo@canary
2. Remove the pnpm-workspace.yaml
3. Run pnpm run dev
4. Turbo throws × root task //#dev (turbo dev) looks like it invokes turbo and might cause a loop

Additional context

No response

@cjkihl cjkihl added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Oct 6, 2024
@anthonyshew anthonyshew added area: logging Improvements to logging and removed needs: triage New issues get this label. Remove it after triage kind: bug Something isn't working labels Oct 6, 2024
@anthonyshew anthonyshew changed the title Missleading error when pnpm-workspace.yaml is missing Misleading error when pnpm-workspace.yaml is missing Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: logging Improvements to logging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants