Skip to content
This repository was archived by the owner on Oct 30, 2025. It is now read-only.

Commit 6729c1e

Browse files
authored
Change hostName to nodeName (#12)
This changes the `hostName` variable to be `nodeName` which better explains what it is supposed to capture.
1 parent 6696e1a commit 6729c1e

File tree

5 files changed

+11
-10
lines changed

5 files changed

+11
-10
lines changed

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ const tracer = new Tracer(
1515
serviceName: 'my-first-service',
1616
environment: process.env.ENVIRONMENT,
1717
dc: process.env.DC,
18-
podName: process.env.PODNAME,
19-
hostName: process.env.HOSTNAME,
18+
podName: process.env.POD_NAME,
19+
nodeName: process.env.NODE_NAME,
2020
sampler: new DeterministicSampler(process.env.TRACE_SAMPLE_RATE),
2121
},
2222
{
@@ -85,7 +85,8 @@ But a better solution is to use the `setupHttpTracing` helper function like the
8585

8686
```ts
8787
async function handler(req: IncomingMessage, res: ServerResponse) {
88-
const { spanContext, fetch } = setupHttpTracing({ tracer, req, res });
88+
const spanContext = setupHttpTracing({ tracer, req, res });
89+
const fetch = setupFetchTracing({ spanContext });
8990
await sleep(100, spanContext);
9091
const output = await fetch(upstreamUrl);
9192
res.write(output);

examples/db-example.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ const tracer = new Tracer(
1111
serviceName: 'db-example',
1212
environment: process.env.ENVIRONMENT,
1313
dc: process.env.DC,
14-
podName: process.env.PODNAME,
15-
hostName: process.env.HOSTNAME,
14+
podName: process.env.POD_NAME,
15+
nodeName: process.env.NODE_NAME,
1616
sampler: new DeterministicSampler(process.env.TRACE_SAMPLE_RATE),
1717
},
1818
{

examples/routing-example.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ const tracer = new Tracer(
1414
serviceName: 'routing-example',
1515
environment: process.env.ENVIRONMENT,
1616
dc: process.env.DC,
17-
podName: process.env.PODNAME,
18-
hostName: process.env.HOSTNAME,
17+
podName: process.env.POD_NAME,
18+
nodeName: process.env.NODE_NAME,
1919
sampler: new DeterministicSampler(process.env.TRACE_SAMPLE_RATE),
2020
},
2121
{

src/shared.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export interface TracerOptions {
88
environment?: string;
99
dc?: string;
1010
podName?: string;
11-
hostName?: string;
11+
nodeName?: string;
1212
sampler?: SamplerBase;
1313
}
1414

src/span.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,15 +74,15 @@ export class Span {
7474
environment,
7575
dc,
7676
podName,
77-
hostName,
77+
nodeName,
7878
} = this.tracerOptions;
7979
this.event.addField('duration_ms', duration);
8080
this.event.addField('name', this.name);
8181
this.event.addField('service_name', serviceName);
8282
this.event.addField('environment', environment);
8383
this.event.addField('dc', dc);
8484
this.event.addField('pod_name', podName);
85-
this.event.addField('host_name', hostName);
85+
this.event.addField('node_name', nodeName);
8686
this.event.addField('trace.trace_id', this.traceId);
8787
this.event.addField('trace.span_id', this.spanId);
8888
this.event.addField('trace.parent_id', this.parentId);

0 commit comments

Comments
 (0)