Skip to content

Commit 2eef409

Browse files
committed
Revert "Improve reliability of owner stacks for async I/O errors (#81501)"
This reverts commit 465c221.
1 parent 8abbb3d commit 2eef409

File tree

3 files changed

+15
-17
lines changed

3 files changed

+15
-17
lines changed

packages/next/src/server/lib/patch-fetch.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ export function createPatchedFetcher(
559559
cacheSignal = null
560560
}
561561

562-
return await makeHangingPromise<Response>(
562+
return makeHangingPromise<Response>(
563563
workUnitStore.renderSignal,
564564
'fetch()'
565565
)
@@ -669,7 +669,7 @@ export function createPatchedFetcher(
669669
cacheSignal.endRead()
670670
cacheSignal = null
671671
}
672-
return await makeHangingPromise<Response>(
672+
return makeHangingPromise<Response>(
673673
workUnitStore.renderSignal,
674674
'fetch()'
675675
)
@@ -1010,7 +1010,7 @@ export function createPatchedFetcher(
10101010
cacheSignal.endRead()
10111011
cacheSignal = null
10121012
}
1013-
return await makeHangingPromise<Response>(
1013+
return makeHangingPromise<Response>(
10141014
workUnitStore.renderSignal,
10151015
'fetch()'
10161016
)
@@ -1044,7 +1044,7 @@ export function createPatchedFetcher(
10441044
switch (workUnitStore.type) {
10451045
case 'prerender':
10461046
case 'prerender-client':
1047-
return await makeHangingPromise<Response>(
1047+
return makeHangingPromise<Response>(
10481048
workUnitStore.renderSignal,
10491049
'fetch()'
10501050
)

packages/next/src/server/use-cache/use-cache-wrapper.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,7 @@ export function cache(
821821
)
822822

823823
if (dynamicAccessAbortController.signal.aborted) {
824-
return await makeHangingPromise(
824+
return makeHangingPromise(
825825
workUnitStore.renderSignal,
826826
dynamicAccessAbortController.signal.reason.message
827827
)
@@ -886,7 +886,7 @@ export function cache(
886886
if (cacheSignal) {
887887
cacheSignal.endRead()
888888
}
889-
return await makeHangingPromise(
889+
return makeHangingPromise(
890890
workUnitStore.renderSignal,
891891
'dynamic "use cache"'
892892
)
@@ -935,7 +935,7 @@ export function cache(
935935
// transformed with an async function, before being passed into
936936
// the "use cache" function, which escapes the instrumentation.
937937
if (workUnitStore.allowEmptyStaticShell) {
938-
return await makeHangingPromise(
938+
return makeHangingPromise(
939939
workUnitStore.renderSignal,
940940
'dynamic "use cache"'
941941
)
@@ -1030,7 +1030,7 @@ export function cache(
10301030
if (cacheSignal) {
10311031
cacheSignal.endRead()
10321032
}
1033-
return await makeHangingPromise(
1033+
return makeHangingPromise(
10341034
workUnitStore.renderSignal,
10351035
'dynamic "use cache"'
10361036
)
@@ -1087,7 +1087,7 @@ export function cache(
10871087
)
10881088

10891089
if (result.type === 'prerender-dynamic') {
1090-
return await result.hangingPromise
1090+
return result.hangingPromise
10911091
}
10921092

10931093
const { stream: newStream, pendingCacheEntry } = result

test/e2e/app-dir/cache-components-errors/cache-components-errors.test.ts

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -554,11 +554,10 @@ describe('Cache Components Errors', () => {
554554
"description": "Route "/dynamic-root": A component accessed data, headers, params, searchParams, or a short-lived cache without a Suspense boundary nor a "use cache" above it. See more info: https://nextjs.org/docs/messages/next-prerender-missing-suspense",
555555
"environmentLabel": "Server",
556556
"label": "Console Error",
557-
"source": "app/dynamic-root/page.tsx (59:26) @ fetchRandom
558-
> 59 | const response = await fetch(
559-
| ^",
557+
"source": "app/dynamic-root/page.tsx (45:56) @ FetchingComponent
558+
> 45 | {cached ? await fetchRandomCached(nonce) : await fetchRandom(nonce)}
559+
| ^",
560560
"stack": [
561-
"fetchRandom app/dynamic-root/page.tsx (59:26)",
562561
"FetchingComponent app/dynamic-root/page.tsx (45:56)",
563562
"Page app/dynamic-root/page.tsx (22:9)",
564563
"LogSafely <anonymous>",
@@ -568,11 +567,10 @@ describe('Cache Components Errors', () => {
568567
"description": "Route "/dynamic-root": A component accessed data, headers, params, searchParams, or a short-lived cache without a Suspense boundary nor a "use cache" above it. See more info: https://nextjs.org/docs/messages/next-prerender-missing-suspense",
569568
"environmentLabel": "Server",
570569
"label": "Console Error",
571-
"source": "app/dynamic-root/page.tsx (59:26) @ fetchRandom
572-
> 59 | const response = await fetch(
573-
| ^",
570+
"source": "app/dynamic-root/page.tsx (45:56) @ FetchingComponent
571+
> 45 | {cached ? await fetchRandomCached(nonce) : await fetchRandom(nonce)}
572+
| ^",
574573
"stack": [
575-
"fetchRandom app/dynamic-root/page.tsx (59:26)",
576574
"FetchingComponent app/dynamic-root/page.tsx (45:56)",
577575
"Page app/dynamic-root/page.tsx (27:7)",
578576
"LogSafely <anonymous>",

0 commit comments

Comments
 (0)