Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment GitHub workflows #860

Open
johnnygerard opened this issue Jan 25, 2024 · 1 comment
Open

Update deployment GitHub workflows #860

johnnygerard opened this issue Jan 25, 2024 · 1 comment

Comments

@johnnygerard
Copy link

johnnygerard commented Jan 25, 2024

Your workflows (preview.yaml, production.yaml) still use actions/checkout@v2 instead of actions/checkout@v4.

Also, the workflows specify the npm version vercel@canary. Why not use vercel@latest?

@josips9
Copy link

josips9 commented Dec 9, 2024

When using these files, while trying to deploy to Vercel I'm getting this error:

Type error: 'Navbar' cannot be used as a JSX component.
Its type '() => Promise' is not a valid JSX element type.
Type '() => Promise' is not assignable to type '(props: any, deprecatedLegacyContext?: any) => ReactNode'.
Type 'Promise' is not assignable to type 'ReactNode'.
24 |
25 |

26 |
| ^
27 | <main
28 | id="skip"
29 | className="min-h-[calc(100dvh-4rem)] md:min-h[calc(100dvh-5rem)]"

I didn't change anything in the nextjs-subscription-starter template.

When deploying directly from Vercel everything goes flawlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants