We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current behavior
Using ResponseCookies.delete({ name: '__Secure-some-cookie', secure: true }) to delete a secure cookie fails. The cookie simply doesn't get deleted.
ResponseCookies.delete({ name: '__Secure-some-cookie', secure: true })
Expected behavior/code
The cookie should get deleted.
Possible solution
Pass all options given to delete to the contained set call.
delete
set
Additional context/screenshots
Investigating the code, I found that the secure flag, that can be passed as an option to delete isn't passed to the set call.
edge-runtime/packages/cookies/src/response-cookies.ts
Line 94 in 0b9479a
In general, please don't offer parameters for the function that have 0 influence on the execution.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Bug Report
Current behavior
Using
ResponseCookies.delete({ name: '__Secure-some-cookie', secure: true })
to delete a secure cookie fails. The cookie simply doesn't get deleted.Expected behavior/code
The cookie should get deleted.
Possible solution
Pass all options given to
delete
to the containedset
call.Additional context/screenshots
Investigating the code, I found that the secure flag, that can be passed as an option to
delete
isn't passed to theset
call.edge-runtime/packages/cookies/src/response-cookies.ts
Line 94 in 0b9479a
In general, please don't offer parameters for the function that have 0 influence on the execution.
The text was updated successfully, but these errors were encountered: