-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug with setting --set badges
in CLI
#52
Comments
When I debug I found that https://github.com/assemble/verb/blob/master/lib/transforms/init/load.js, and it seems that all is okey -- setting and getting the path. The problem is loading the template files from templates directory. |
I already fixed this locally. I'll push up the fix in a bit |
btw, verb is almost instant for me. the only "slowness" is when it hits the github API to pull down reflinks. |
ookey.
almost, lol. 30-40ms for just one badge isn't instant for me. Yea, there's no logic to use verb for just one badge (and no one would use it like that), but yea. |
9.82 ms for me:
well, there are always tradeoffs. for me, verb runs almost as fast as gulp - there will be a small bump because verb has to load the user's environment (package.json, IMHO, given that verb is a documentation generator, micro-optimization will never be as important as user convenience and good documentation. Honestly I haven't even gotten a chance to release what I would consider "the cool stuff". Verb can easily generate full documentation websites for example. There is no documentation generator on github, in any language, that can touch what verb is able to do. Especially given that verb can implement the others as plugins. All I'm trying to say is, please stop mentioning the speed. I don't mean to say I don't care, but I don't care ;) |
No, no, I understand it is absolutely normal to run as fast as gulp. But yea, maybe I should stop thinking about gulp family, lol 😈 Ping me we you pushed it up, cuz I need it to try (and maybe start using) new v0.7 verb :) 👍 |
I tried everything but cant figure out how to define custom templates path with
--set
. I mean, there pops up some ugly stack trace.when I set
--set badges="/home/charlike/dev/verb-config/badges
which is https://github.com/verbose/readme-badges with costumized templates.I guess the bug is also for
--set includes
and etc.The text was updated successfully, but these errors were encountered: