Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date and Time field values getting wiped #54

Open
LauraMontgomery opened this issue Feb 21, 2025 · 2 comments
Open

Date and Time field values getting wiped #54

LauraMontgomery opened this issue Feb 21, 2025 · 2 comments

Comments

@LauraMontgomery
Copy link

Describe the bug

When using the Date and Time fields in TableMaker, any previous values added get wiped if I make any changes to the Table Columns. Times I have spotted this include:

  • Adding a new column
  • Editing the name of a column heading
  • Updating the values in a dropdown field

Related, but I suppose technically a different issue, is that date fields also load with NaN/NaN/NaN - which I understand as a developer, but might scare the normal end-user.

Steps to reproduce

  1. Create a table with Date and Time columns
    Note that the date column field is populated with NaN/NaN/NaN, although the field itself works perfectly fine.

Image

  1. Populate table with some data, and save the entry

Image

  1. After the entry has saved, add a new column to the table
    Note that the previously entered values for Date and Time have now been wiped, alongside Date showing NaN/NaN/NaN again

Image

Craft CMS version

5.6.4

Plugin version

5.0.4

Multi-site?

No

Additional context

No response

@engram-design
Copy link
Member

Fixed for the next release. To get this early, run composer require verbb/tablemaker:"dev-craft-5 as 5.0.4".

@LauraMontgomery
Copy link
Author

Hey, thank you for this. I've given it a test and it does seem like the Time field input is sorted but I'm still getting the same issues on the Date field. I've clear caches just in case it was something like that causing my issues, but still behaving strangely unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants