Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail on deploy:log_revision #6

Open
webroru opened this issue Jun 8, 2018 · 1 comment
Open

Fail on deploy:log_revision #6

webroru opened this issue Jun 8, 2018 · 1 comment

Comments

@webroru
Copy link

webroru commented Jun 8, 2018

Hello again,

If option aws_no_reboot_on_create_ami is false, the instance goes to reboot before deploy is ended. Because you add task to update ASG after deploy:finishing. But according capistrano flow (http://capistranorb.com/documentation/getting-started/flow/) after deploy:finishing there still are number of tasks.

capistrano-asg/lib/capistrano/asg.rb

Line 53 in 147bbbc

after('deploy:finishing', 'asg:scale')

webroru added a commit to webroru/capistrano-asg that referenced this issue Jun 8, 2018
@webroru
fix Fail on deploy:log_revision
b6774b2 
veracross#6
@webroru webroru mentioned this issue Jun 8, 2018
Open
@craigmcnamara craigmcnamara mentioned this issue Aug 1, 2018
Closed
@webroru
Copy link
Author

webroru commented Apr 23, 2019

@sixfeetover @smerickson @bvogelzang ping?

@webroru webroru mentioned this issue Apr 23, 2019
Merged
webroru added a commit to webroru/capistrano-asg that referenced this issue Apr 23, 2019
@webroru
fix Fail on deploy:log_revision
c2c8efb 
veracross#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@webroru