Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix undefined type issue with nested fragment spreads #3351

Open
wants to merge 1 commit into
base: minor
Choose a base branch
from

Conversation

jhmen
Copy link

@jhmen jhmen commented Feb 7, 2025

Description

This pull request addresses a bug where GraphQL types in the TypeTree were becoming undefined when using nested fragment spreads. The issue stemmed from the way fragment children were being merged within the getTypeNodeByPath function. It was performing a shallow merge, failing to properly incorporate type information from nested fragments. Relates to #3337.

Checklist

📌 Always:

  • [x ] I have set a clear title
  • [ x] My PR is small and contains a single feature
  • [x ] I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 7, 2025 0:22am

Copy link
Contributor

github-actions bot commented Feb 7, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jhmen
Copy link
Author

jhmen commented Feb 7, 2025

I have read the CLA Document and I hereby sign the CLA

Copy link

sonarqubecloud bot commented Feb 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant