Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendure admin : payment methods : display name in columns #1613

Closed
christopheblin opened this issue Jun 8, 2022 · 2 comments
Closed

Vendure admin : payment methods : display name in columns #1613

christopheblin opened this issue Jun 8, 2022 · 2 comments
Labels
P4: low Non-critical, workarounds exist status: reproduction needed 🔁 Reproduction of described behaviour needed by core team

Comments

@christopheblin
Copy link
Contributor

christopheblin commented Jun 8, 2022

Is your feature request related to a problem? Please describe.
I have multiple channels. Each channels has a payment method with code = "stripe" but with a unique name (like 'stripe-channel1').

the fact to have the same code is for the storefronts to be able to "hardcode" the method whatever the channel without using eligiblePaymentMehods before

So when I go to Settings > Payment methods, I only see a bunch of 'stripe'

Describe the solution you'd like
If the name would be displayed in addition to the code (like in the shipping methods), I coud distinguish easily between the methods

Describe alternatives you've considered
Looking in the db by the name and loading the page with url https://xxx/admin/settings/payment-methods/xxx

@christopheblin
Copy link
Contributor Author

In fact, there is a deeper problem : when you have multiple methods with the same code, the method becomes unusable in the 'default' channel

the problem is not for shippingMethod because setOrderShippingMethod uses the id (whereas addPaymentToOrder uses the PM code)

-> so, generally speaking, it is not a good idea to have 2 PM with the same code

and maybe there could be a unique index on this column in the db to enforce this "restriction" ?

@michaelbromley michaelbromley added this to the v2.0 milestone Jul 1, 2022
@michaelbromley michaelbromley moved this to 📅 Planned in Vendure OS Roadmap Jul 1, 2022
@dlhck dlhck added the status: reproduction needed 🔁 Reproduction of described behaviour needed by core team label Sep 24, 2024
@dlhck dlhck removed this from the v2.0 milestone Sep 24, 2024
@dlhck dlhck added the P4: low Non-critical, workarounds exist label Sep 24, 2024
@dlhck dlhck moved this from 📅 Planned to 👀 Under consideration in Vendure OS Roadmap Sep 24, 2024
@martijnvdbrug
Copy link
Collaborator

Both issues seem to be fixed in Vendure 3.1.1

  • Table is showing both name and Code
  • Default channel can show payment methods with the same code
    Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4: low Non-critical, workarounds exist status: reproduction needed 🔁 Reproduction of described behaviour needed by core team
Projects
Status: 👀 Under consideration
Development

No branches or pull requests

4 participants