Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vegacapsule Improvement Ideas #44

Open
gordsport opened this issue Mar 18, 2022 · 3 comments
Open

Vegacapsule Improvement Ideas #44

gordsport opened this issue Mar 18, 2022 · 3 comments

Comments

@gordsport
Copy link
Contributor

gordsport commented Mar 18, 2022

This issue is a parent issue for any improvements we will make to the vega capsule. The original MVP for Vegacapsule was that we would have system tests running locally, in CI and be able to use it to add/remove nodes (testing of validators joining/leaving and snapshots).

Current issues list

Currently DV does some configuration/set up that vegacapsule doesn't (multisig etc..), in order to make vegacapsule useful for development pleas capture any ideas in this ticket. I will then summarise into a bullet list *in this comment) ahead of a meeting to talk around them and prioritise into tickets to be delivered. Replicating DV may not be the best approach so we should add ideas of things we want/need maybe not just what we have today...

Suggestions:

  1. validators added to the multisig control contracts
@wwestgarth
Copy link
Contributor

I think the having the validators added to the multisig control contracts is a must, because I don't think we can say that a valid network has been started if the validators perf-scores are all zero. The system-tests have a manual step to do this so you could argue that this would also benefit the system tests as well if this was brought into vegacapsule.

The next thing is what makes a usable network, and for me thats some parties with some vega staked because without being able to propose a market you can barely do anything. The config could look like:

parties {
   count = 7 // generates 7 key pairs and stakes some vega
}

with something like vegacapsule state parties to see their public keys. DV also faucets in some builitin-assets, but I can live without this being automatic because its much much easier to do and depends a lot more on your genesis file. But staking vega is something you'll always need to do.

@karlem
Copy link
Contributor

karlem commented Mar 29, 2022

@wwestgarth I think number point number 1 make a lot of sense. @jeremyletang has mentioned that we can build a CLI to Vega to allow users to call ethereum contracts.. That would help a lot with it.

The second point - yeah sounds reasonable but it should not be part of tool itself. I think the system of plugins should be introduced and this could be one of them.

@MuthuVega
Copy link
Contributor

@fkondej @daniel1302 - Are there any plans to have vegacapsule running in a Private network - similar to what we have for dv?
Think having it will remove a lot of dependency from the local machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants