Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC]: Support Arbitrum bridge #10610

Closed
8 tasks done
ValentinTrinque opened this issue Feb 12, 2024 · 0 comments · Fixed by #10632 or vegaprotocol/vegacapsule#432
Closed
8 tasks done

[EPIC]: Support Arbitrum bridge #10610

ValentinTrinque opened this issue Feb 12, 2024 · 0 comments · Fixed by #10632 or vegaprotocol/vegacapsule#432
Assignees
Labels

Comments

@ValentinTrinque
Copy link
Contributor

ValentinTrinque commented Feb 12, 2024

Support for the Arbitrum bridge in the core.

Green path

  1. Keep in mind we have to deduplicate chain events based on the hash
    1. Convert all assets to be associated to the configured ethereum chain (using chain ID).
    2. Hash with Chain ID, if seen, dedup, if not seen, hash without chain ID, if seen dedup, if not, track event hash with with chain ID.
  2. Add RPC config to enable arbitrum ETHClient.
  3. Support in governance
    2. add chain ID to governance payload
    3. validation of asset with bridge based on chain ID
    5. add asset to asset pool and banking
    6. on enactment, emit signature that tells the bridge it shall allow the use of asset (support multiple chain ID)
    7. enable asset in collateral engine (support multiple chain ID)
  4. Support deposit & withdraw
    1. Support chain ID in chain event (resolved from asset ID to chain ID)
    2. Validation using the correct ETHClient (ensure use of the arbitrum one)
    3. Finish deposit
    4. Withdrawal: emit signatures that are slightly modified: ethbridge = old signatures, arbitrum = new signatures. to be refined
  5. Validation package (To refined, no ticket associated yet)
    1. Add and remove validators: add_signer / remove_signer
    2. Question: impact on rewards if bridge incorrectly setup ? Option: If one is not correctly setup -> no payment.
  6. Proposal to update an asset
  7. Support in API
    1. Add chain ID were needed (bundles, etc).

Additional links

Tasks

  1. arbitrum bridges enhancement
    ValentinTrinque
  2. arbitrum bridges enhancement
    ValentinTrinque
  3. arbitrum bridges enhancement
    ValentinTrinque
  4. arbitrum bridges enhancement
    ValentinTrinque
  5. arbitrum bridges
    ValentinTrinque
  6. api arbitrum bridges enhancement
    ValentinTrinque
  7. arbitrum bridges feature validators selection
    wwestgarth
  8. arbitrum bridges network parameters
    Sohill-Patel ValentinTrinque
@ValentinTrinque ValentinTrinque added enhancement New feature or request bridges labels Feb 12, 2024
@ValentinTrinque ValentinTrinque added this to the 🏛️ Colosseo milestone Feb 12, 2024
@gordsport gordsport changed the title [EPIC] Support Arbitrum bridge [EPIC]: Support Arbitrum bridge Mar 13, 2024
@Sohill-Patel Sohill-Patel linked a pull request Mar 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants