Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label annotation cell text can wrap #886

Closed
johnwalley opened this issue Jul 14, 2023 · 0 comments · Fixed by #891
Closed

Label annotation cell text can wrap #886

johnwalley opened this issue Jul 14, 2023 · 0 comments · Fixed by #891
Assignees
@johnwalley
Labels
🐛 bug A but that should be dealt with soon

Comments

@johnwalley
Copy link
Contributor

Description

Label annotations should never take up more than one 'line'.

Steps to Reproduce

  1. Go to the Trading app
  2. Reduce the browser window size as much as possible while still retaining the 'full-screen' responsive layout

Expected behavior

Perhaps a max-width, with no wrapping, and ellipsis?

Screenshots

Screenshot 2023-07-14 at 14 02 51
@johnwalley johnwalley added the 🐛 bug A but that should be dealt with soon label Jul 14, 2023
@johnwalley johnwalley self-assigned this Jul 14, 2023
@johnwalley johnwalley linked a pull request Jul 17, 2023 that will close this issue
fix(candlestick): annotation text should not wrap #891
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnwalley johnwalley

Labels
🐛 bug A but that should be dealt with soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(candlestick): annotation text should not wrap vegaprotocol/pennant
1 participant
@johnwalley