Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable price monitoring bands annotation #854

Closed
1 of 3 tasks
mattrussell36 opened this issue Jun 30, 2023 · 2 comments · Fixed by #870
Closed
1 of 3 tasks

Re-enable price monitoring bands annotation #854

mattrussell36 opened this issue Jun 30, 2023 · 2 comments · Fixed by #870
Assignees
@johnwalley
Labels
pennant

Comments

@mattrussell36
Copy link
Contributor

mattrussell36 commented Jun 30, 2023 •
edited by bwallacee
Loading

The Chore

These aren't showing due to changing api.

Tasks

  • Adjust chart specs
  • Re-enable
  • Test

Additional details / background info
@johnwalley johnwalley self-assigned this Jul 3, 2023
@mattrussell36
Copy link
Contributor Author

@ben-vegaprotocol @daro-maj can we update the specs for charts here

@bwallacee bwallacee mentioned this issue Jul 6, 2023
Merged
@bwallacee
Copy link

@mattrussell36 PR here: vegaprotocol/specs#1813

@johnwalley johnwalley linked a pull request Jul 12, 2023 that will close this issue
feat: support multiple price monitoring bounds #870
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnwalley johnwalley

Labels
pennant
Projects
Frontend Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support multiple price monitoring bounds vegaprotocol/pennant
3 participants
@johnwalley @mattrussell36 @bwallacee