Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve study pane configuration #835

Closed
8 of 9 tasks
mattrussell36 opened this issue Jun 20, 2023 · 1 comment
Closed
8 of 9 tasks

Improve study pane configuration #835

mattrussell36 opened this issue Jun 20, 2023 · 1 comment
Assignees
Labels

Comments

@mattrussell36
Copy link
Contributor

mattrussell36 commented Jun 20, 2023

The Chore

It would be useful to be able to pass callback to the chart which will be called when the internal panes change size. Additionally it would be good to be able to set the initial size

ACs

  • I can set the height of the study panes
  • Studies should NOT grow proportionally when the chart canvas gets larger. ALL extra size when the chart grows should go to the main chart.
  • Studies should only shrink when the chart area gets smaller IF necessary to fit the chart and all the studies
    • Something like: if the chart would get smaller than the biggest study (because of resizing or the adding of studies), reduce ALL of the studies proportionally as the canvas gets smaller, BUT don't persist the studies temporarily smaller sizes (do persist if they are then manually sized though)
  • The chart should greedily take the extra space.

Tasks

  • Expose pane onChange callback
  • Allow setting initial pane size in px/%
  • Adjust pane resizing logic
  • Dev
  • Test

Additional details / background info

@mattrussell36 mattrussell36 changed the title Expose allotment onChange callback and initial pane size Improve study pane configuration Aug 31, 2023
@mattrussell36 mattrussell36 self-assigned this Sep 5, 2023
@bwallacee
Copy link

@mattrussell36 if I have multiple studies open and resize a study below another to be taller, it shrinks the study above. And vice versa, if i shrink a study below, the stufy above grows.

I would have though that the study above would remain the same size in both scenarios?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants