Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price annotation and candles get out of sync #833

Closed
mattrussell36 opened this issue Jun 5, 2023 · 3 comments
Closed

Price annotation and candles get out of sync #833

mattrussell36 opened this issue Jun 5, 2023 · 3 comments
Assignees
Labels
🐛 bug A but that should be dealt with soon pennant Testing 🧪

Comments

@mattrussell36
Copy link
Contributor

mattrussell36 commented Jun 5, 2023

Description

After some period of time the price annotation gets out of sync with the last candle. Additionally the decimal precision is lost.

Steps to Reproduce

  1. Open a candle chart
  2. Wait
  3. Use market sim to try to increment time to try to reproduce this
  4. Eventually notice that the price annotation does not align with the last price on a candle

Expected behavior

Price annotation should match the closing price of the latest candle

Screenshots

image (2)

Additional context

https://vegaprotocol.slack.com/archives/C037STCKMGC/p1685903922105259

@mattrussell36 mattrussell36 added 🐛 bug A but that should be dealt with soon pennant labels Jun 5, 2023
@macqbat macqbat self-assigned this Oct 19, 2023
@macqbat
Copy link
Contributor

macqbat commented Oct 20, 2023

Cannot reproduce it. Possible, it was fixed in some other previous works. Can you QA guys can confirm it?

@bwallacee bwallacee self-assigned this Oct 25, 2023
@bwallacee
Copy link

I can't recreate this using market-sim so far. I'm not sure if we want to close this issue or just icebox it for now? cc @JonRay15 , @mattrussell36

@JonRay15
Copy link

JonRay15 commented Dec 4, 2023

We cannot reproduce and think this likely will have been fixed by the change to use the last candle when Core changed their retention policy on the candles API. Closing this.

@JonRay15 JonRay15 closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A but that should be dealt with soon pennant Testing 🧪
Projects
Archived in project
Development

No branches or pull requests

6 participants