Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make simple chart mode even simpler #283

Open
2 tasks
mattrussell36 opened this issue Jun 25, 2021 · 0 comments
Open
2 tasks

Make simple chart mode even simpler #283

mattrussell36 opened this issue Jun 25, 2021 · 0 comments
Labels

Comments

@mattrussell36
Copy link
Contributor

mattrussell36 commented Jun 25, 2021

We need the simple chart to be even simpler. At the moment if simple charts are shown in a long list if you try to scroll down and your mouse is over the chart your will just zoom.

Additionally we want click events on the chart itself, at the moment if you click and drag to resize the study you will invoke the click event.

We need to either:
a) Make simple mode disable zoom and pan and resizing the study, so there would be no change to the component API
b) Add additional options to disable these bits of functinality specifically. This would extend the options prop like so:

type Options = {
  ...
  disableZoom?: boolean
  disableStudyResize?: boolean
};

Critieria:

  • Prevent being able to drag to resize the study
  • Prevent zooming and panning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants