Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buy / Sell should not be stored per order type in local storage #6576

Open
3 tasks
JonRay15 opened this issue Jun 20, 2024 · 0 comments
Open
3 tasks

Buy / Sell should not be stored per order type in local storage #6576

JonRay15 opened this issue Jun 20, 2024 · 0 comments
Labels
branch-develop Work for the next planned release of frontend apps

Comments

@JonRay15
Copy link
Contributor

JonRay15 commented Jun 20, 2024

The Chore

Currently Buy / Sell is being stored specific to the order type.

So the following bad scenario occurs:

  1. I happen to have selected limit order at first
  2. I decide I want to sell and set that
  3. I decide actually I need a market order and select it
  4. Suddently I am back on buy, because the last time I was on market order on this market I was on buy
  5. Without noticing it I end up buying instead and am BIG SAD

Acceptance criteria

  • BUY / SELL should be independent of the order type
  • Only key the stored deal ticket state based on the market ID alone
  • BUY / SELL should persist and never change based on other inputs ... only by you actually setting it

Additional details / background info

@JonRay15 JonRay15 added the branch-develop Work for the next planned release of frontend apps label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-develop Work for the next planned release of frontend apps
Projects
Status: Todo
Development

No branches or pull requests

1 participant