Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to single master market list w/filters #6086

Open
14 tasks done
JonRay15 opened this issue Mar 22, 2024 · 1 comment · May be fixed by #6671
Open
14 tasks done

Move to single master market list w/filters #6086

JonRay15 opened this issue Mar 22, 2024 · 1 comment · May be fixed by #6671
Assignees
@asiaznik
Labels
branch-develop Work for the next planned release of frontend apps

Comments

@JonRay15
Copy link
Contributor

JonRay15 commented Mar 22, 2024 •
edited by asiaznik
Loading

User Story

As a user
I want to have a single master view on markets with filters and tabs on my market page
So that I can switch easily to what I need to see

Ideally as part of this also deliver:

Acceptance Criteria

  • Get to single view containing all of Open / Proposed / Closed which is basically the OPEN view now ... we are optimising for the OPEN markets first
  • Anywhere we dont have appropriate info for proposed / closed just show a dash instead
  • Have a dropdown to allow filtering for status (Open / Proposed / Closed) which is always defaulted to Open
  • Have a dropdown to allow filtering for Asset to allow filtering for settlement asset
    • Will need to include the chain name in brackets
    • For Spot markets will need to include any market where the asset is either the base or the quote
  • Have a search box that supports standard text search
  • If any results are being excluded from the search result by filters display some text beneath the results saying "X results excluded due to applied filters, click to remove filters"
  • Have a series of quick filter buttons to support
    • All
    • Perp
    • Future
    • Spot
  • Re-order the market selector dropdown product filter so that it follows the same order

Sketch

Figma Link ↳

Default State
01 Markets@2x

Excluded Results
02 Excluded Results@2x

Dropdown Filters & Search

Showing:

  • Default, Hover and Active states
  • Single and Multi Select
Market Filter States@2x

Market Switcher with the updated tab order ↳
@JonRay15 JonRay15 mentioned this issue Mar 22, 2024
Open
5 tasks
@JonRay15 JonRay15 changed the title Markets page filters and toggles Move to single master market list May 1, 2024
@JonRay15 JonRay15 changed the title Move to single master market list Move to single master market list w/filters May 1, 2024
@JonRay15 JonRay15 added branch-develop Work for the next planned release of frontend apps and removed design refine labels Jun 13, 2024
@asiaznik asiaznik self-assigned this Jun 26, 2024
@JonRay15
Copy link
Contributor Author

When we do this ... see if the changes adress concerns in here: #6601

@JonRay15 JonRay15 mentioned this issue Jun 26, 2024
Open
3 tasks
@asiaznik asiaznik linked a pull request Jul 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asiaznik asiaznik

Labels
branch-develop Work for the next planned release of frontend apps
Projects
Frontend Engineering
Status: Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(trading): single market list vegaprotocol/frontend-monorepo
2 participants
@asiaznik @JonRay15