Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show volume discount programme proposal on governance #4398

Closed
1 of 9 tasks
ckpringle opened this issue Jul 26, 2023 · 5 comments · Fixed by #5022
Closed
1 of 9 tasks

Show volume discount programme proposal on governance #4398

ckpringle opened this issue Jul 26, 2023 · 5 comments · Fixed by #5022
Assignees

Comments

@ckpringle
Copy link

ckpringle commented Jul 26, 2023

Story

As a user
I want to see when a proposal has been made for an update to the volume discount programme
So that I know to look to see what has changed before voting

UPDATE: Volume discount schemes will just be a network parameter, so we will get most of this for free, but we need to check how we display multi-line network params

UPDATE 18th Sept: Volume discount schemes are NOT just network params! 😂 We will need to support another proposal type

Acceptance Criteria

  • Governance app can handle a volume discount proposal types
  • On the proposal details screen, we have some acceptable way of rendering the tiers. These will appear as under sketches. We have a few examples of existing params like this (margin scaling factors, price monitoring bounds) but I dont know I have ever seen us try to update one and seen how the UI displays it. Its not clear to me how the UI woudl handle this currently given it only shows the changed param at the very top currently
  • I can see proposal JSON

Tasks

  • Check with Valentin to understand how and where this data is being presented (is it a new proposal type? YES)
  • Specs reviewed and created or adjusted
  • Implementation
  • Testing (unit and/or e2e)
  • Code review
  • QA review

Sketch

Network parameter will appear like this in the API:

Image

Additional details / background info

Spec: vegaprotocol/specs#1829 see https://github.com/vegaprotocol/specs/blob/9ae928fb95dfb511ae5e7a29c280ef0d9a8cf7b0/protocol/0083-VDPR-volume_discount_program.md

@JonRay15
Copy link
Contributor

As per vegaprotocol/specs#1912

It is not clear yet whether volume discount will be on the governances API or will be a network parameter .... optimisation things going on. On hold until we know.

@JonRay15
Copy link
Contributor

JonRay15 commented Sep 1, 2023

At the moment Core have not built volume discounts ... so this can be parked

@JonRay15
Copy link
Contributor

JonRay15 commented Sep 6, 2023

Note we have now confirmed this is all on network param

@JonRay15
Copy link
Contributor

Think this is not yet built for now

@JonRay15
Copy link
Contributor

This has changed again and WILL be a new proposal type now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants