-
Notifications
You must be signed in to change notification settings - Fork 7
refactor: replace doc_auto_cfg with doc_cfg
#52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change SummaryThis PR updates the Rust feature flag from ✅ Review complete - no issues found The change is correct and necessary:
|
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
alexveecle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not follow completely the linked issues, but seems... right?
|
You can also check the error message where it explicitly mentions the merge: https://github.com/veecle/freertos-integration/actions/runs/18135434346/job/51612819143?pr=30 (Different repo as we don't test this in |
|
Ah, thanks! I still don't have full understanding of the issue, but that makes me feel better about adding my +1 :D |
|
We should update the pinned nightly so that the CI generated docs keep the annotations. |
Yeah, maybe nightly needs to be updated :\
|
#54 to bump nightly. |
|
I'd like it combined, since this is a behavioral change with the currently pinned version ( |
|
(we should probably open another issue about flaky someip tests and try to fix them again, they seem to be even flakier on the github-hosted runners) |
`doc_auto_cfg` has been merged into `doc_cfg` in rust-lang/rust#138907. Signed-off-by: Julian Schindel <[email protected]>
Signed-off-by: Julian Schindel <[email protected]>
45eae9c to
24836d8
Compare
Signed-off-by: Julian Schindel <[email protected]>
24836d8 to
ed4902e
Compare
doc_auto_cfghas been merged intodoc_cfgin rust-lang/rust#138907.Also bumps the Rust nightly version to actually capture the
doc_cfgchange.Fixes: DEV-1000