Skip to content

Conversation

@arctic-alpaca
Copy link
Member

@arctic-alpaca arctic-alpaca commented Sep 30, 2025

doc_auto_cfg has been merged into doc_cfg in rust-lang/rust#138907.

Also bumps the Rust nightly version to actually capture the doc_cfg change.

Fixes: DEV-1000

@claude
Copy link

claude bot commented Sep 30, 2025

Change Summary

This PR updates the Rust feature flag from doc_auto_cfg to doc_cfg in veecle-os/src/lib.rs:5. The change replaces the deprecated doc_auto_cfg feature with doc_cfg following the merge of rust-lang/rust#138907.

✅ Review complete - no issues found

The change is correct and necessary:

  • Properly updates to the current Rust documentation feature
  • Maintains the same functionality for conditional documentation generation
  • Follows the upstream consolidation in the Rust compiler

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.64%. Comparing base (3a7bfaa) to head (ed4902e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
veecle-telemetry-server/src/main.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
veecle-os-data-support-someip/src/string.rs 100.00% <100.00%> (ø)
veecle-os-runtime/src/datastore/reader.rs 88.09% <ø> (ø)
veecle-telemetry-server/src/main.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a7bfaa...ed4902e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

alexveecle
alexveecle previously approved these changes Oct 1, 2025
Copy link
Contributor

@alexveecle alexveecle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not follow completely the linked issues, but seems... right?

@arctic-alpaca
Copy link
Member Author

arctic-alpaca commented Oct 1, 2025

You can also check the error message where it explicitly mentions the merge: https://github.com/veecle/freertos-integration/actions/runs/18135434346/job/51612819143?pr=30

(Different repo as we don't test this in veecle-os in CI)

@alexveecle
Copy link
Contributor

Ah, thanks! I still don't have full understanding of the issue, but that makes me feel better about adding my +1 :D

@Nemo157
Copy link
Contributor

Nemo157 commented Oct 1, 2025

We should update the pinned nightly so that the CI generated docs keep the annotations.

@alexveecle alexveecle dismissed their stale review October 1, 2025 07:34

Yeah, maybe nightly needs to be updated :\

@arctic-alpaca
Copy link
Member Author

#54 to bump nightly.

@Nemo157
Copy link
Contributor

Nemo157 commented Oct 1, 2025

I'd like it combined, since this is a behavioral change with the currently pinned version (doc_cfg on this version just allows you to write #[doc(cfg(...))] manually).

@Nemo157
Copy link
Contributor

Nemo157 commented Oct 1, 2025

(we should probably open another issue about flaky someip tests and try to fix them again, they seem to be even flakier on the github-hosted runners)

`doc_auto_cfg` has been merged into `doc_cfg` in rust-lang/rust#138907.

Signed-off-by: Julian Schindel <[email protected]>
Signed-off-by: Julian Schindel <[email protected]>
@arctic-alpaca arctic-alpaca added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit 574720a Oct 1, 2025
31 of 33 checks passed
@arctic-alpaca arctic-alpaca deleted the julian/doccfg branch October 1, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants