Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Net P1] Code review and Test --> thor/transactions package #1723

Open
claytonneal opened this issue Jan 20, 2025 · 1 comment · May be fixed by #1881
Open

[New Net P1] Code review and Test --> thor/transactions package #1723

claytonneal opened this issue Jan 20, 2025 · 1 comment · May be fixed by #1881
Assignees
@GrandinLuc
Milestone
2.0.0-beta (Pre-R...

Comments

@claytonneal
Copy link
Member

  • Code review and comment
  • Agree potential changes
  • Add PRs to make changes and merge
  • Add unit tests (note: unit tests should use mocking so not making http requests)
  • Add doc comments to all classes, methods, types etc
@claytonneal claytonneal added this to the 2.0.0-beta (Pre-Release) milestone Jan 20, 2025
@claytonneal claytonneal changed the title [New Net] Code review and Test --> thor/transactions package [New Net P1] Code review and Test --> thor/transactions package Jan 20, 2025
@GrandinLuc GrandinLuc self-assigned this Feb 26, 2025
@victhorbi victhorbi mentioned this issue Mar 3, 2025
Open
@GrandinLuc GrandinLuc linked a pull request Mar 11, 2025 that will close this issue
1723 new net p1 code review and test thortransactions package #1881
Open
13 tasks
@GrandinLuc
Copy link
Collaborator

Depends on #1841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GrandinLuc GrandinLuc

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta (Pre-Release)
Development

Successfully merging a pull request may close this issue.

1723 new net p1 code review and test thortransactions package vechain/vechain-sdk-js
2 participants
@claytonneal @GrandinLuc