Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Error in convolution computation #17

Open
ludovic-carre opened this issue Mar 28, 2018 · 6 comments
Open

Error in convolution computation #17

ludovic-carre opened this issue Mar 28, 2018 · 6 comments
Labels

Comments

@ludovic-carre
Copy link

ludovic-carre commented Mar 28, 2018

Aren't there mistakes in the images 1 to 8 for numerical_padding_strides-*.pdf ? For instance shouldn't the second element of the first row be 5 ?
Here is what is computed:

                   0 0 0 0 0 0 0                                               1 6 5
                   0 2 2 3 3 3 0                    Original result:           7 10 9
2 0 1              0 0 1 3 0 3 0                                               7 10 8
1 0 0     *        0 2 3 0 1 3 0       ---->
0 1 1              0 3 3 2 1 2 0                                               1 5 6
                   0 3 3 0 2 3 0                    My result:                 7 8 3
                   0 0 0 0 0 0 0                                               3 10 4

If I am correct then the mistakes are also on this website: http://deeplearning.net/software/theano/tutorial/conv_arithmetic.html

PS: Sorry for the chaotic display, can't figure it out.

@blgnksy
Copy link

blgnksy commented Mar 28, 2018

What is your stride for your example?

@ludovic-carre
Copy link
Author

Stride 2 as you can see on the website linked.

@blgnksy
Copy link

blgnksy commented Apr 1, 2018

Your result is correct.

@fvisin
Copy link
Collaborator

fvisin commented Apr 3, 2018

Hi @PiggyGenius , thank you for your bug report.
I took the liberty of editing your comment to fix the display :)

I can confirm that you computed the correct outcome for a stride 2 convolution and that the second animation of the Theano tutorial is indeed incorrect. We shall fix that. (@vdumoulin I don't think I have access anymore. Do you? Drop me a line when you have time.)

By 1 to 8 for numerical_padding_strides-*.pdf do you mean the animations generated by the code? I didn't have time to re-run the code myself, but we will look into it as soon as we have some time.

Thank you again for the bug report.

@fvisin fvisin added the bug label Apr 3, 2018
@ludovic-carre
Copy link
Author

ludovic-carre commented Apr 3, 2018

I was referring to the images in the pdf folder of this repository but I apparently made a mistakes. I thought they were the same images as the ones of the theano gif.

@fvisin
Copy link
Collaborator

fvisin commented Apr 3, 2018

Great, thanks for reporting this. We will look into it as soon as possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants