From ca2d98c7374d9855943dfff0db2ecff88916f20c Mon Sep 17 00:00:00 2001 From: vathymut Date: Mon, 17 Jan 2022 15:43:47 -0500 Subject: [PATCH] Fix default number of CPUs available. --- .Rbuildignore | 3 ++- R/rf-helpers.R | 2 -- cran-comments.md | 8 +++++++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/.Rbuildignore b/.Rbuildignore index 408f199..9755494 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -9,4 +9,5 @@ ^NEWS\.md$ ^docs$ ^README.md$ -^README.Rmd$ \ No newline at end of file +^README.Rmd$ +^CRAN-SUBMISSION$ diff --git a/R/rf-helpers.R b/R/rf-helpers.R index 336c512..f922b2c 100644 --- a/R/rf-helpers.R +++ b/R/rf-helpers.R @@ -26,7 +26,6 @@ classifier_args <- function(data, probability = TRUE, write.forest = TRUE, replace = FALSE, - num.threads = parallel::detectCores() - 1L, save.memory = FALSE, respect.unordered.factors = TRUE, verbose = FALSE, @@ -59,7 +58,6 @@ residual_args <- function(data, num_trees = 500L, response_name = "label") { importance = "none", write.forest = TRUE, replace = FALSE, - num.threads = parallel::detectCores() - 1L, save.memory = FALSE, respect.unordered.factors = TRUE, verbose = FALSE, diff --git a/cran-comments.md b/cran-comments.md index 89e1368..59d1cdd 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,4 +1,10 @@ -# Test environments +## Resubmission + +This is a resubmission. In this version, I changed default argument to satisfy +Julia Haider's request: "Please ensure that you do not use more than 2 cores in +your examples [...]. Please fix and resubmit." + +## Test environments * local Windows 10 x64, R installation, R 4.0.5 * R-hub Ubuntu Linux 20.04.1 LTS, R-release, GCC