Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional in linkDirectionalParticles does not use correct return value #341

Open
kohlerpop1 opened this issue Dec 31, 2023 · 1 comment

Comments

@kohlerpop1
Copy link

kohlerpop1 commented Dec 31, 2023

Describe the bug
Conditional in linkDirectionalParticles seems to be using the first return value for all nodes instead of the return value within the specific conditional.

To Reproduce
Steps to reproduce the behavior:

  1. Create linkDirectionalParticles conditional that evaluates to false first/once, returning 1.
  2. Have conditional return > 1 for other nodes.

Expected behavior
It should used the returned value for each link to determine how many particles are on it at each time.

Screenshots
image
This is confirmed to be false on the first conditional and true on some others.

Desktop (please complete the following information):
image

Smartphone (please complete the following information):
NA - Not tested!

Disclaimer: I did check out Dynamically Update linkDirectionalParticles and this does not seem to be exactly what I am trying to do.

@vasturiano
Copy link
Owner

@kohlerpop1 thanks for reaching out.

I'm unable to reproduce your issue. Also because I don't have insight into your data. In my case it does respect the return value of the linkDirectionalParticles method for each independent link.

If you're still having issues, could you make a simple reproducing example on https://codepen.io/ ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants