Skip to content

Commit c298cc4

Browse files
Eric SotoEric Soto
authored andcommitted
fix(node-amqp-connection-manager): forces back a dependency that has a bug.
node-amqp-connection-manager, starting with v3.4.0, has a bug where connectionOptions are not passed into the underlying AMQPLIB. This caused AMQPCaccon to not be able to connect to self-signed TLS servers, for example, nor any other server that requires connectionOptions. For now, package.json of this library is keeping node-amqp-connection-manager at 3.3.x using the syntax "~3.3.0" since the old syntax "^3.3.2" would in fact allow the dependency to go up to 3.x (and the bug is present in 3.4 and up.) This might be reverted in a future version.
1 parent 2f078ff commit c298cc4

File tree

5 files changed

+67
-11
lines changed

5 files changed

+67
-11
lines changed

examples/src/example-amqp-consumer-batch.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ let amqpCacoon = new AmqpCacoon({
5656
},
5757
onBrokerDisconnect: async (err) => {
5858
// This is an example "Disconnect" event fired off by AMQP Connection Manager
59-
logger.error(`Broker disconnected with error "${err.message}"`);
59+
logger.error(`Broker disconnected with error "${err.err.message}"`);
6060
},
6161
// Important - onChannelConnect will ensure a certain configuration exists in RMQ.
6262
// This might not be needed in environments where RMQ is setup by some other process!

examples/src/example-amqp-consumer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ let amqpCacoon = new AmqpCacoon({
5454
},
5555
onBrokerDisconnect: async (err) => {
5656
// This is an example "Disconnect" event fired off by AMQP Connection Manager
57-
logger.error(`Broker disconnected with error "${err.message}"`);
57+
logger.error(`Broker disconnected with error "${err.err.message}"`);
5858
},
5959
// Important - onChannelConnect will ensure a certain configuration exists in RMQ.
6060
// This might not be needed in environments where RMQ is setup by some other process!

examples/src/example-amqp-publish.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ let amqpCacoon = new AmqpCacoon({
5555
},
5656
onBrokerDisconnect: async (err) => {
5757
// This is an example "Disconnect" event fired off by AMQP Connection Manager
58-
logger.error(`Broker disconnected with error "${err.message}"`);
58+
logger.error(`Broker disconnected with error "${err.err.message}"`);
5959
},
6060
// Important - onChannelConnect will ensure a certain configuration exists in RMQ.
6161
// This might not be needed in environments where RMQ is setup by some other process!

package-lock.json

Lines changed: 63 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"test": "rimraf ./build && tsc && mocha --exit -r ts-node/register ./tests/**/*.test.ts"
1717
},
1818
"dependencies": {
19-
"amqp-connection-manager": "^3.2.3",
19+
"amqp-connection-manager": "~3.3.0",
2020
"amqplib": "^0.8.0",
2121
"lodash": "^4.17.21",
2222
"log4js": "^6.3.0"

0 commit comments

Comments
 (0)