Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/topics/installation.md references exploit venerable below Redis 3.2 and has instructions for init.d #108

Closed
stockholmux opened this issue May 27, 2024 · 1 comment · Fixed by #197

Comments

@stockholmux
Copy link
Member

In pre-publishing review (#91), the following issues were noted:

Note that a Valkey instance exposed to the internet without any security is very simple to exploit, so make sure you understand the above and apply at least a firewall layer.

The firewall is good advice, but the exploit outlined is fixed in 3.2+, this advice should probably be updated to made relevant for 2024/Valkey.

A proper install using an init script is strongly recommended.
Note: The available packages for supported Linux distributions already include the capability of starting the Valkey server from /etc/init.

This section proceeds to go into quite a bit of detail in creating a init.d script. In 2024, would be we better off providing instructions for a service?

@zuiderkwast
Copy link
Contributor

Note that a Valkey instance exposed to the internet without any security is very simple to exploit, so make sure you understand the above and apply at least a firewall layer.

I'm deleting this.

This section proceeds to go into quite a bit of detail in creating a init.d script. In 2024, would be we better off providing instructions for a service?

I agree. I'm changing this a bit, but I don't know by heart how to set up a systemd service. I'll just write that Valkey supports systemd and that this document was written before systemd was widely adapted. I see now on this page https://en.wikipedia.org/wiki/Systemd#Adoption that there are some distros that don't use systemd and Valkey indeed runs on embedded machines so I think I'll keep the init.d stuff around.

I'll also

  • refer to ACL (acl.md) as the primary way to set up AUTH, rather than requirepass.
  • refer to proper TLS (encryption.md) instead of using some 3rd party TLS tunneling software.

zuiderkwast added a commit to zuiderkwast/valkey-doc that referenced this issue Dec 10, 2024
Signed-off-by: Viktor Söderqvist <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants