You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In review before publishing #91, eval-intro.md has several issues:
Has several references that should be primary/replica
Links to an unknown hash docs/topics/protocol#resp-arrays (probably should be #arrays)
Weird bang in front of !SCRIPT in heading (looks like this may have been some sort of now dead markup)
Has references to old versionsIn Redis OSS 5.0, effects replication became the default mode., Starting with Redis OSS 3.2, it is possible to select an alternative replication method., starting with Redis OSS 5.0
The text was updated successfully, but these errors were encountered:
Weird bang in front of !SCRIPT in heading (looks like this may have been some sort of now dead markup)
The "Weird bang" is from the old redis website. All commands in backticks were automatically linked to the command doc pages. The bang prevents this from being interpreted as the SCRIPT command.
I kept it intentionally because I assumed you know about it and I thought we may want to keep this behaviour. I don't like it though since it's kind of hidden secret markup.
It is good to have links between the topics pages and the command pages though, but not every occurrence needs to be linked. How about we link explicitly to the command on the first occurrence on each page?
A script could update all the pages and occurrences of !STUFF throught the pages. (The bangs are present in the replies JSON and commands JSON files too btw.)
zuiderkwast
added a commit
to zuiderkwast/valkey-doc
that referenced
this issue
Dec 10, 2024
In review before publishing #91,
eval-intro.md
has several issues:docs/topics/protocol#resp-arrays
(probably should be#arrays
)!SCRIPT
in heading (looks like this may have been some sort of now dead markup)In Redis OSS 5.0, effects replication became the default mode.
,Starting with Redis OSS 3.2, it is possible to select an alternative replication method.
,starting with Redis OSS 5.0
The text was updated successfully, but these errors were encountered: