Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/topics/data-types.md has references to 'community supported modules' #100

Closed
stockholmux opened this issue May 27, 2024 · 1 comment · Fixed by #197
Closed

/topics/data-types.md has references to 'community supported modules' #100

stockholmux opened this issue May 27, 2024 · 1 comment · Fixed by #197

Comments

@stockholmux
Copy link
Member

The last line of data-types.md has the following passage:

Write your own Valkey module using the modules API or check out the community-supported modules.

The term "community-supported modules" doesn't make much sense in the context of Valkey and it links to a missing page (/docs/topics/modules/).

I would just remove "check out the community-supported modules"

@zuiderkwast
Copy link
Contributor

zuiderkwast commented Dec 10, 2024

It doesn't link to links to modules under topics. It links to ../modules/ (which relative the file topics/data-types.md means /modules/), i.e. https://valkey.io/modules/. IMHO we should put a placeholder page on that address. Later, we should generate the list of modules from the json files we already have (or clean up and replace them with other modules).

If I delete all the links to https://valkey.io/modules/ and https://valkey.io/clients/, then we'll have to locate them again and put them back when we have created these pages. I don't think we'll succeed in doing that.

I'll keep the link for now. I'll just remove the text "community supported". (Maybe we'll divide them into "officially supported" and "3rd party" modules later.)

zuiderkwast added a commit to zuiderkwast/valkey-doc that referenced this issue Dec 10, 2024
Signed-off-by: Viktor Söderqvist <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants