Investigate html5lib-tests encoding cases that are failing #47
Comments
sideshowbarker
changed the title
sideshowbarker
added a commit
that referenced
this issue
Aug 21, 2020
This change makes the parser’s encoding-name matching conform to the current Encoding spec at https://encoding.spec.whatwg.org/#concept-encoding-get — which requires that only leading and trailing whitespace be removed from a string before checking if it matches any valid encoding name. Otherwise, without this change, the parser instead implements https://www.unicode.org/reports/tr22/tr22-8.html#Charset_Alias_Matching — which requires deleting “all characters except a-z, A-Z, and 0-9” from a string before checking if it matches any valid encoding name. That difference makes us fail two html5-tests cases. Relates to #47
|
OK, #48 has a fix for the following.
|
|
OK, #49 has a fix for the following.
|
|
With the fixes in #48 and #49 applied — and with the changes in html5lib/html5lib-tests#130 merged, we will be passing all the html5lib-tests encoding cases. |
sideshowbarker
added a commit
that referenced
this issue
Aug 21, 2020
This change makes the parser’s encoding-name matching conform to the current Encoding spec at https://encoding.spec.whatwg.org/#concept-encoding-get — which requires that only leading and trailing whitespace be removed from a string before checking if it matches any valid encoding name. Otherwise, without this change, the parser instead implements https://www.unicode.org/reports/tr22/tr22-8.html#Charset_Alias_Matching — which requires deleting “all characters except a-z, A-Z, and 0-9” from a string before checking if it matches any valid encoding name. That difference makes us fail two html5-tests cases. Relates to #47
sideshowbarker
added a commit
that referenced
this issue
Aug 31, 2020
This change makes the parser’s encoding-name matching conform to the current Encoding spec at https://encoding.spec.whatwg.org/#concept-encoding-get — which requires that only leading and trailing whitespace be removed from a string before checking if it matches any valid encoding name. Otherwise, without this change, the parser instead implements https://www.unicode.org/reports/tr22/tr22-8.html#Charset_Alias_Matching — which requires deleting “all characters except a-z, A-Z, and 0-9” from a string before checking if it matches any valid encoding name. That difference makes us fail two html5-tests cases. Relates to #47
sideshowbarker
added a commit
that referenced
this issue
Sep 13, 2020
This change makes the parser’s encoding-name matching conform to the current Encoding spec at https://encoding.spec.whatwg.org/#concept-encoding-get — which requires that only leading and trailing whitespace be removed from a string before checking if it matches any valid encoding name. Otherwise, without this change, the parser instead implements https://www.unicode.org/reports/tr22/tr22-8.html#Charset_Alias_Matching — which requires deleting “all characters except a-z, A-Z, and 0-9” from a string before checking if it matches any valid encoding name. That difference makes us fail two html5-tests cases. Relates to #47
hsivonen
pushed a commit
that referenced
this issue
Aug 17, 2021
This change makes the parser’s encoding-name matching conform to the current Encoding spec at https://encoding.spec.whatwg.org/#concept-encoding-get — which requires that only leading and trailing whitespace be removed from a string before checking if it matches any valid encoding name. Otherwise, without this change, the parser instead implements https://www.unicode.org/reports/tr22/tr22-8.html#Charset_Alias_Matching — which requires deleting “all characters except a-z, A-Z, and 0-9” from a string before checking if it matches any valid encoding name. That difference makes us fail two html5-tests cases. Relates to #47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We’re failing 4 test-case types (9 cases in total) in https://github.com/html5lib/html5lib-tests/tree/master/encoding/
As far as I can tell, these cases don’t fail in Firefox.
https://github.com/html5lib/html5lib-tests/blob/master/encoding/tests1.dat#L65
https://github.com/html5lib/html5lib-tests/blob/master/encoding/tests1.dat#L162
https://github.com/html5lib/html5lib-tests/blob/master/encoding/tests1.dat#L314-L347 (6 cases; 2048–8193 characters)
https://github.com/html5lib/html5lib-tests/blob/master/encoding/tests1.dat#L350
The text was updated successfully, but these errors were encountered: