replace with propper validation

[github-actions]

glued-stor/glued/Controllers/ServiceController.php

Line 280 in edca4a9

// TODO replace with propper validation

     * @param  array    $args
     * @return Response Json result set.
     */
    public function buckets_r1(Request $request, Response $response, array $args = []): Response {
        $params = $request->getQueryParams();
        $q = "
        SELECT 
          bin_to_uuid(b.`uuid`, 1) AS `b.uuid`,
          b.name AS `b.name`,
          b.data AS `b.data`,
          bin_to_uuid(bd.`dg`, 1) AS `dg`,
          s.dgStatus
        FROM `t_stor_buckets` b
        LEFT JOIN t_stor_bucket_dgs bd ON bd.bucket = b.uuid
        LEFT JOIN (
          SELECT DISTINCT dgUuid, dgStatus
          FROM v_stor_status
        ) s ON s.dgUuid = bin_to_uuid(bd.dg, 1)
        ";

        $res = $this->mysqli->execute_query($q, []);
        $data = $res->fetch_all(MYSQLI_ASSOC);

        $data = [
                'timestamp' => microtime(),
                'status' => 'Buckets r1 OK',
                'data' => $data,
                'service' => basename(__ROOT__),
            ];
        return $response->withJson($data);
    }

    public function buckets_c1(Request $request, Response $response, array $args = []): Response {
        $params = $request->getQueryParams();
        $this->status();
        // TODO replace with propper validation
        $contentTypeHeader = $request->getHeaderLine('Content-Type') ?? '';
        if ($contentTypeHeader !== 'application/json') { throw new \Exception('Invalid Content-Type. Please set `Content-Type: application/json', 400); }
        $body = $request->getParsedBody();
        $uuid = \Ramsey\Uuid\Uuid::uuid4()->toString();
        if (!isset($body['name'])) { throw new \Exception('Mandatory $.name not provided.'); }
        if (!isset($body['dgs'])) { throw new \Exception('Mandatory $.dgs not provided.'); }
        if (!is_array($body['dgs'])) { throw new \Exception('Mandatory $.dgs is not a list (array).'); }

        $q1 = "INSERT INTO `t_stor_buckets` (`uuid`, `data`) VALUES (uuid_to_bin(?,true), ?)";
        $q2 = "INSERT INTO `t_stor_bucket_dgs` (`bucket`,`dg`) VALUES (uuid_to_bin(?,true), uuid_to_bin(?,true))";

        try {
            $this->mysqli->begin_transaction();
            $this->mysqli->execute_query($q1, [ $uuid, json_encode($body) ]);
            foreach ($body['dgs'] as $dg) {
                $this->mysqli->execute_query($q2, [$uuid, $dg]);
            }
            $this->mysqli->commit();
        } catch (\mysqli_sql_exception $e) {
            if ($e->getCode() === 1452) { throw new \Exception("Unknown devicegroup UUID.", 400); }
            elseif ($e->getCode() === 1062) { throw new \Exception("The bucket:devicegroup association already exists.", 400);
            } else { throw $e; }
        }

        $data = [
            'timestamp' => microtime(),
            'status' => "Bucket {$uuid} ({$body['name']}) created.",
            'params' => $params,
            'service' => basename(__ROOT__),
        ];