Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG-REPORT] BinnerTime object has not attribute combine_expressions #2071

Open
thisismeleaving opened this issue Jun 2, 2022 · 7 comments · May be fixed by #2167
Open

[BUG-REPORT] BinnerTime object has not attribute combine_expressions #2071

thisismeleaving opened this issue Jun 2, 2022 · 7 comments · May be fixed by #2167
Labels
bug

Comments

@thisismeleaving
Copy link

thisismeleaving commented Jun 2, 2022 •
edited
Loading

Description
After upgrading from vaex v4.7.0 This call:

import vaex
from numpy import datetime64

vx = vaex.from_dict({
    'dt' : [
        datetime64('2016-12-01T10:00:00'),
        datetime64('2016-12-01T11:00:00')
    ],
    'tmp_idx': [
        '111_223.5',
        '111_223.5'
    ]
})
grouped = vx.groupby(by=[vaex.BinnerTime.per_day(vx.dt), vx.tmp_idx])

Now throws the following error:

AttributeError: 'BinnerTime' object has not attribute 'combine_expressions'

Software information

  • Vaex version (import vaex; vaex.__version__): 4.9.1
  • Vaex was installed via: pip
  • OS: Ubuntu
@thisismeleaving
Copy link
Author

This is still an issue in v4.9.2

@thisismeleaving thisismeleaving changed the title [BUG-REPORT] 'BinnerTime' object has not attribute 'combine_expressions' [BUG-REPORT] BinnerTime object has not attribute combine_expressions Jun 24, 2022
@thisismeleaving
Copy link
Author

still an issue as of v4.11.1

@JovanVeljanoski JovanVeljanoski linked a pull request Aug 12, 2022 that will close this issue
Open
2 tasks
@fllara
Copy link

fllara commented Aug 31, 2022

I'm experiencing this issue with 4.12

@nelmondo
Copy link

I'm experiencing this issue with 4.14

@JovanVeljanoski
Copy link
Member

We've look at this in some detail.. unfortunately it clashes with other features and it might not be fixable (at least not in the short term). @maartenbreddels can explain this better.

As a work-around, i would suggest casting the datatime column to string in the required format, and then do the groupby. Does this make sense? I know it is annoying..

@nelmondo
Copy link

nelmondo commented Dec 28, 2022 •
edited
Loading

We've look at this in some detail.. unfortunately it clashes with other features and it might not be fixable (at least not in the short term). @maartenbreddels can explain this better.

As a work-around, i would suggest casting the datatime column to string in the required format, and then do the groupby. Does this make sense? I know it is annoying..

I change the format from datetime to string, but I can't solve this issue??? please check this... (I'm using with 4.16.0)

@nelmondo
Copy link

When does it fix???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: multi key groupby when one of the keys is BinnerTime vaexio/vaex
4 participants
@thisismeleaving @nelmondo @JovanVeljanoski @fllara