Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute JSDoc annotations for better vscode-lit-plugin support #257

Closed
20 tasks done
web-padawan opened this issue Jul 16, 2020 · 0 comments
Closed
20 tasks done
Assignees
Labels
typescript TypeScript definitions issue

Comments

@web-padawan
Copy link
Member

web-padawan commented Jul 16, 2020

We recommend VSCode lit-plugin for creating TypeScript views, and we use it also in our TypeScript examples

It turns out that our components need @attr JSDoc annotation for camelCase properties to avoid warnings.
See vaadin/vaadin-grid#1774 and vaadin/vaadin-combo-box#896

Let's update the components to include JSDoc annotations where needed.

@web-padawan web-padawan added the typescript TypeScript definitions issue label Jul 16, 2020
@web-padawan web-padawan self-assigned this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript TypeScript definitions issue
Projects
None yet
Development

No branches or pull requests

1 participant