Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe convert into multimodule and validate workflows #8

Open
Artur- opened this issue Apr 5, 2018 · 1 comment
Open

Maybe convert into multimodule and validate workflows #8

Artur- opened this issue Apr 5, 2018 · 1 comment

Comments

@Artur-
Copy link
Member

Artur- commented Apr 5, 2018

The current setup is non-standard in many ways and has the following issues:

  • It can't be extended in any way
  • It can't produce a demo war
  • The Maven part is more complex than needed and hard to understand if you do understand Maven

Consider changing this into a multimodule project with one module for the addon and another for the test/demo (people tend to only create one UI and use it for both)

What needs testing is that this does not harm the development experience:

  • Making a change in the add-on should not require mvn install or similar to test the demo in Eclipse
  • Making a change in the add-on should not require mvn install or similar to test the demo in IDEA

Potentially the multi-module feature in Jetty 9.4.7 will help:

As of Jetty 9.4.7, when using jetty:run in a multi-module build, it is no longer necessary to build each of the modules that form dependencies of the webapp first. Thus, if your webapp depends on other modules in your project and they are present in the reactor at the same time, jetty will use their compiled classes rather than their jar files from your local maven repository.
@mvysny
Copy link
Member

mvysny commented Aug 17, 2022

I've created a multi-module project here: https://github.com/mvysny/component-starter-flow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants