chore: amend JDT-reported errors (#3348)

* Fix what JDT considers errors

* Restore test functionality

* Restore optionals in JsonValuePlugin

Author: cromoteca

packages/java/engine-core/src/test/java/com/vaadin/hilla/engine/commandrunner/CommandRunnerTest.java

@@ -195,7 +195,7 @@ public ProcessHandle.Info getCurrentProcessInfo() {
                 return new MockProcessInfo();
             }
 
-            private class MockProcessInfo implements ProcessHandle.Info {
+            class MockProcessInfo implements ProcessHandle.Info {
 
                 @Override
                 public Optional<String> command() {

packages/java/parser-jvm-core/src/test/java/com/vaadin/hilla/parser/models/ClassRefSignatureModelTests.java

@@ -629,7 +629,7 @@ static class Sample {
         private @Foo List<String> topLevelParametrizedDependency;
 
         @Retention(RetentionPolicy.RUNTIME)
-        @Target(ElementType.TYPE_USE)
+        @Target({ ElementType.TYPE_USE, ElementType.FIELD })
         @interface Bar {
         }
 

packages/java/parser-jvm-plugin-backbone/src/main/java/com/vaadin/hilla/parser/plugins/backbone/JsonValuePlugin.java

@@ -10,8 +10,6 @@
 import com.vaadin.hilla.parser.plugins.backbone.nodes.TypedNode;
 import org.jspecify.annotations.NonNull;
 
-import java.lang.reflect.Method;
-import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Optional;
@@ -64,8 +62,12 @@ private Optional<Class<?>> getValueType(Class<?> cls) {
     }
 
     private Optional<Class<?>> findValueType(Class<?> cls) {
-        return Arrays.stream(cls.getMethods())
-                .filter(method -> method.isAnnotationPresent(JsonValue.class))
-                .map(Method::getReturnType).findAny();
+        for (var method : cls.getMethods()) {
+            if (method.isAnnotationPresent(JsonValue.class)) {
+                return Optional.of(method.getReturnType());
+            }
+        }
+
+        return Optional.empty();
     }
 }

packages/java/parser-jvm-utils/src/test/java/com/vaadin/hilla/parser/utils/annotatedowner/AnnotatedOwnerUtilsTests.java

@@ -56,7 +56,7 @@ public void should_NotGetAnnotationsForGrandOwner(AnnotatedType type,
     }
 
     @Retention(RetentionPolicy.RUNTIME)
-    @Target(ElementType.TYPE_USE)
+    @Target({ ElementType.TYPE_USE, ElementType.FIELD })
     @interface Bar {
     }
 

packages/java/tests/spring/security/src/main/java/com/vaadin/flow/spring/fusionsecurity/data/AccountRepository.java

@@ -5,7 +5,7 @@
 import org.springframework.data.jpa.repository.JpaRepository;
 import org.springframework.data.jpa.repository.Query;
 
-public interface AccountRepository extends JpaRepository<Account, String> {
+public interface AccountRepository extends JpaRepository<Account, Integer> {
 
     @Query("Select a from Account a where a.owner.username = ?1")
     Optional<Account> findByOwner(String username);

packages/java/tests/spring/security/src/main/java/com/vaadin/flow/spring/fusionsecurity/data/UserInfoRepository.java

@@ -2,7 +2,7 @@
 
 import org.springframework.data.jpa.repository.JpaRepository;
 
-public interface UserInfoRepository extends JpaRepository<UserInfo, String> {
+public interface UserInfoRepository extends JpaRepository<UserInfo, Integer> {
 
     public UserInfo findByUsername(String username);
 }