Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha testing of Vaadin 24.6.0.alpha3 vs new Flow features #20459

Open
5 tasks done
mshabarov opened this issue Nov 13, 2024 · 11 comments
Open
5 tasks done

Alpha testing of Vaadin 24.6.0.alpha3 vs new Flow features #20459

mshabarov opened this issue Nov 13, 2024 · 11 comments
Assignees
Labels

Comments

@mshabarov
Copy link
Contributor

mshabarov commented Nov 13, 2024

Test the happy path of these new features:

  • WebPush notification options
  • setDragImage
  • exclude Vaadin components
  • easier config for SpringServlet
  • Add support for customizable projectFileExtensions
@mshabarov mshabarov converted this from a draft issue Nov 13, 2024
@mshabarov mshabarov changed the title Test 24.6 alpha Alpha testing of Vaadin 24.6.0.alpha3 vs new Flow features Nov 13, 2024
@mshabarov mshabarov self-assigned this Nov 15, 2024
@mshabarov
Copy link
Contributor Author

For anyone willing to start this - I'd love to try and test:
-exclude Vaadin components
-easier config for SpringServlet

@caalador
Copy link
Contributor

  • Web push - ok
  • Drag image - ok
  • exclude Vaadin components - works, but no documentation
  • easier config for SpringServlet - ok, no doc?
    Skipping file extensions as I did that feature.

@mshabarov
Copy link
Contributor Author

vaadin/docs#3913

@mcollovati
Copy link
Collaborator

mcollovati commented Nov 15, 2024

  • setDragImage - ok
  • easier config for SpringServlet - ok
  • frontendExtraFileExtensions - ok, but seems to miss docs. Also see question below

Add support for customizable projectFileExtensions: tested and works when importing things like @CssImport("some.scss").
The new frontendExtraFileExtensions seems not to be documented in https://vaadin.com/docs/latest/flow/production/production-build.
A question: I tried set frontendExtraFileExtensions=boh and to import a file into a JS script included with @JsModule ont the view. The JavaScript contains import something from 'Frontend/my.boh?raw';. However, my.boh is not included in the stats JSON. Is this expected?

Side note, the maven plugin documentation seems a bit outdated. For example, it lists an includes setting that does not seem to exist.

@caalador
Copy link
Contributor

I would expect it to be there if it is handled by vite.

As boh marked with ?raw vite imports is as a String and it is thus not handled as a file, mening that vite didn't handle it and it will not show up.

@mcollovati
Copy link
Collaborator

Got it. Thanks for clarification.

@mshabarov
Copy link
Contributor Author

exclude Vaadin components
Does it's job for React and Lit based Vaadin apps.

However, I got these info messages, even though I've already excluded components and copilot:

        <dependency>
            <groupId>com.vaadin</groupId>
            <artifactId>vaadin</artifactId>
            <exclusions>
                <exclusion>
                    <groupId>com.vaadin</groupId>
                    <artifactId>vaadin-core-components</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>com.vaadin</groupId>
                    <artifactId>copilot</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

message:

2024-11-18T12:14:57.440+02:00  INFO 6446 --- [onPool-worker-2] c.v.f.server.frontend.TaskUpdateImports  :

  Failed to find the following imports in the `node_modules` tree:
      - @vaadin/list-box/src/vaadin-list-box.js
      - @vaadin/number-field/src/vaadin-number-field.js
      - @vaadin/grid/src/vaadin-grid-sorter.js
      - ....

See exclude-vaadin-components.txt

@tltv is this expected? Could we avoid these messages?

@mshabarov
Copy link
Contributor Author

This would be great to resolve before beta #20490

@mshabarov
Copy link
Contributor Author

vaadin/docs#3921

@tltv
Copy link
Member

tltv commented Nov 18, 2024

With <artifactId>vaadin</artifactId> it includes pro component dependencies, which afaik depends on core components. Try changing that to vaadin-core and it should work. This is documentation issue and need to clear that pro components need to be excluded too by using only vaadin-core dependency.

@mshabarov
Copy link
Contributor Author

mshabarov commented Nov 18, 2024

Thanks, why I couldn't resolve it by myself 😄
Nothing bothers me after I added this:

 <dependency>
            <groupId>com.vaadin</groupId>
            <artifactId>vaadin-core</artifactId>
            <exclusions>
                <exclusion>
                    <groupId>com.vaadin</groupId>
                    <artifactId>vaadin-core-components</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>com.vaadin</groupId>
                    <artifactId>copilot</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>com.vaadin</groupId>
                    <artifactId>vaadin-icons-flow</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

These three exclusions have to be documented, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ⚒️ In progress
Development

No branches or pull requests

4 participants