Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent setting both login listeners and form action #6669

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: prevent setting both login listeners and form action #6669

wants to merge 1 commit into from

Commits on Sep 24, 2024

  1. fix: prevent setting both login listeners and form action 

    Setting both login listeners and form action can cause
unexpected behaviors because of concurrent processing of
form submission processing and login event.
For example, if form submission ends in a session ID change
and a redirect to a different page, the UIDL request may
fail with a session expiration response, causing the Flow
client to reload the page and potentially cancel the ongoing
redirection.
In addition, after from submission, the login event would
be sent to a dismissed UI.
This change prevents setting both action and login listeners
throwing an exception.

References #12640
    @mcollovati
    mcollovati committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0576e2d View commit details
    Browse the repository at this point in the history