fix: update formula bar after the other executions are done #6208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@ugur-vaadin , would you like to proceed with this PR in the future and open it for the review? |
|
I can revisit this one during the upcoming CF and see what remains to be done |
ugur-vaadin
force-pushed
the
fix-update-formula-bar-after-the-other-executions-are-done
branch
from
d9878ed
to
3b6e190
Compare
ugur-vaadin
force-pushed
the
fix-update-formula-bar-after-the-other-executions-are-done
branch
from
3b6e190
to
2644485
Compare
DiegoCardoso
approved these changes
Sep 10, 2024
ugur-vaadin
force-pushed
the
fix-update-formula-bar-after-the-other-executions-are-done
branch
from
2644485
to
1aea1d0
Compare
|
ugur-vaadin
deleted the
fix-update-formula-bar-after-the-other-executions-are-done
branch
|
This ticket/PR has been released with Vaadin 24.5.0.alpha17 and is also targeting the upcoming stable 24.5.0 version. |
vursen
pushed a commit
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR defers the update of the formula bar so that all the calculations are done beforehand. This fixes the case where the formula bar displays the number using the wrong locale when the cell is selected using the address field. This also applies for the case changing sheet after setting the value and returning to the sheet.
Partially fixes #5731
Type of change
Checklist