-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataChangeEvent is not fired when GridListDataView#setFilter is called #5303
Comments
Closing with the same reasoning provided here: #5304 (comment) |
@sissbruecker according to justification setFilter implementation of DataProvider should then changed not to emit the event, right? Now there is discrepancy. |
I mean, I would say yes, conceptually that doesn't make sense. But looking at the implementation that might not be possible and may also be undesirable as developers might rely on that event in that case. I'm also not sure if the inconsistency is a big problem that needs fixing, the data provider and data view APIs work differently, and the data provider implementation has a lot of baggage that can't be changed anymore. But you're probably better off discussing this with the Flow team, maybe they have a different interpretation of data, data view and the data change event than I do. I'd suggest to create a ticket there to discuss the inconsistency and what the intended behavior is. If there is an outcome that requires changes to the components, then we're up for taking PRs for that. |
Description
DataChangeEvent is not fired when GridListDataView#setFilter is called. Note, the event is fired when filter is set via DataProvider instead. This should be analogous.
Expected outcome
Event is fired.
Minimal reproducible example
Steps to reproduce
Run the unit test
Environment
Vaadin version(s): Vaadin 24.1.4
OS:
Browsers
No response
The text was updated successfully, but these errors were encountered: