Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Can it loop? #30

Open
SMUsamaShah opened this issue Apr 17, 2023 · 11 comments
Open

[Feature] Can it loop? #30

SMUsamaShah opened this issue Apr 17, 2023 · 11 comments

Comments

@SMUsamaShah
Copy link

Is it possible to also have last image same as first image making an infinite loop?

@GeorgLegato
Copy link
Collaborator

I am going to add a second image. so, if you provide same image, then yes

@GeorgLegato
Copy link
Collaborator

btw, if I add init image, and select ZOOM IN, this image is at the end of animation.
This should be fixed as well. btw, inpainting and zoom in is poor, because an INPAINT model has to txt2prompt which is very poor result.

IF (ZOOM IN)
IF (INIT_IMG)
Out(INIT_IMG) -> outpaint -> outpaint ... -> n
ELSE
Out (Prompt With non-inpaint-model) -> switch to inpaint model -> outpaint ... -> n
ELSE
... ?

@GeorgLegato
Copy link
Collaborator

GeorgLegato commented Apr 17, 2023

@v8hid let us add two Global Settings:
Model to use for txt2img (if no init image)
Model to use for steps between (inpainting model)

first version easy, just textboxes, later improve on fancy select dropdowon

@v8hid
Copy link
Owner

v8hid commented Apr 17, 2023

@v8hid let us add two Global Settings: Model to use for txt2img (if no init image) Model to use for steps between (inpainting model)

first version easy, just textboxes, later improve on fancy select dropdowon

Users are already using WebUI, They can easily use the Txt2Img tab for the initial image (They can also play with it to get the best result and then use it as an initial image).
Don't forget we don't want to rebuild the things that already exist.
It also might cause some conflicts in loading and might cause VRAM exhaustion and we need to handle a lot of stuff, It's better to let Automatic1111 handle it and we just used the shared model.
What do you think?

@GeorgLegato
Copy link
Collaborator

@v8hid let us add two Global Settings: Model to use for txt2img (if no init image) Model to use for steps between (inpainting model)
first version easy, just textboxes, later improve on fancy select dropdowon

Users are already using WebUI, They can easily use the Txt2Img tab for the initial image (They can also play with it to get the best result and then use it as an initial image). Don't forget we don't want to rebuild the things that already exist. It also might cause some conflicts in loading and might cause VRAM exhaustion and we need to handle a lot of stuff, It's better to let Automatic1111 handle it and we just used the shared model. What do you think?

check the code:
If no image provided, TXT2IMG will be called using the first prompt in list. and this with a inpainting model.
I am nearly done switching between models .-)
original code:
image

@v8hid
Copy link
Owner

v8hid commented Apr 17, 2023

I don't know how we can implement a clean loop video.
I have just one idea: We can use F.I.L.M to interpolate between the last frame and the first frame like this one here:
interpolated

Not so clean but it improves as the frames become more similar.

@v8hid
Copy link
Owner

v8hid commented Apr 17, 2023

I am nearly done switching between models .-)

I know what you mean and you are absolutely right, but we can put the effort to improve more necessary features like the ones you implemented perfectly, and of course, we can work on stuff like this later!

@v8hid v8hid changed the title Can it loop? [Feature] Can it loop? Apr 18, 2023
@SMUsamaShah
Copy link
Author

I don't know how we can implement a clean loop video.

If you are zooming in, like animation above, the final image will emerge from center pixel. As a starter, instead of interpolating like example animation, better idea would be to zoom to the final image emerging from center. The boundaries won't match but that's still a better start than interpolation.

@GeorgLegato
Copy link
Collaborator

we have implemented the so called EXIT IMAGE, if you define same img for init and exit, we have a loop. not a perfect blend, but a good starting point, next release

@zrichz
Copy link

zrichz commented Jun 16, 2023

just a check - that the last frame of the saved animation is not simply the EXIT image, but the frame before the exit image, since otherwise the loop will stutter as it has 2 frames of the exit image (one at the start and one at the end) :)

@bigsk1
Copy link

bigsk1 commented Jul 8, 2023

maybe I am missing something but I am trying to have a starting image and zoom into the image and a ai generated world opens up. In this case an eye is the start and then zoom into the eye! Currently it either uses the prompts and last frame is the eye or first frame is the eye and zooms back out.

Am I missing something here? Would it not make sense to have a starting image and zoom into it?

00037-572710569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants