Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create llm cache block builder only when the user requests an update. #1826

Closed
vegetableysm opened this issue Mar 14, 2024 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request llm stale

Comments

@vegetableysm
Copy link
Collaborator

Describe your problem

Currently, we will fetch and get a block object if user request a cache block(update or query) and create a builder from this block object. Then delete the block object. There exist an extra memory copy process when create a new builder. We can keep the block object to server the query request from the user and create a new builder only when the user requests an update.

@vegetableysm vegetableysm added enhancement New feature or request llm labels Mar 14, 2024
@vegetableysm vegetableysm self-assigned this Mar 14, 2024
@github-actions github-actions bot added the stale label Apr 12, 2024
Copy link
Contributor

/cc @vegetableysm, this issus/pr has had no activity for for a long time, could you folks help to review the status ?
To suppress further notifications,

  • for issues,
    • if it is waiting for further response from the reporter/author, please help to add the label requires-further-info,
    • if you have already started working on it, please add the label work-in-progress to the issue,
    • if this issue requires further designing discussion and not in current plan, or won't be fixed, please add the label requires-further-discussion or wontfix to the issue,
  • for pull requests,
    • if you are still working on it and it is not ready for reviewing, please convert this pull request as draft PR,
    • if you have decided to hold this development on, please add the requires-further-discussion label to the pull request.
      Thanks!

@sighingnow
Copy link
Member

Has this issue been fixed or not?

@vegetableysm
Copy link
Collaborator Author

Has this issue been fixed or not?
No. We pull block object only when we access the block, but we will rebuild the builder. We can change it to build the builder only for update and serve the query via block in the future.

@vegetableysm vegetableysm closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request llm stale
Projects
None yet
Development

No branches or pull requests

2 participants