We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think this line in the implementation is not safe it could cause rounding issues:
https://github.com/uzyn/bigdenary/blob/master/mod.ts#L31C7-L31C60
For example the following number will fail: 0.0023537
You can see the problem with this if you try the following calculation:
// 23536.999999999996 instead of 23537 0.0023537 * Math.pow(10, 7)
The response will be a float instead of an integer so it will fail with BigInt.
The text was updated successfully, but these errors were encountered:
You will see the following JS error:
RangeError - The number 23536.999999999996 cannot be converted to a BigInt because it is not an integer
Sorry, something went wrong.
No branches or pull requests
I think this line in the implementation is not safe it could cause rounding issues:
https://github.com/uzyn/bigdenary/blob/master/mod.ts#L31C7-L31C60
For example the following number will fail: 0.0023537
You can see the problem with this if you try the following calculation:
The response will be a float instead of an integer so it will fail with BigInt.
The text was updated successfully, but these errors were encountered: